Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redirect Links from App after Verification #227

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Conversation

andy-t-wang
Copy link
Contributor

Adding an anchor will prevent the page from refreshing once you've confirmed with Idkit. Should also be fine for when you re use the same verification since it'll just add another anchor. See video below

RPReplay_Final1703784992.MP4

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
idkit-js-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 9:27pm

@andy-t-wang andy-t-wang changed the title Fix Redirect Links from App after Verification fix: Redirect Links from App after Verification Dec 28, 2023
adds a comment explaining why the url fragment is added
Copy link
Collaborator

@0xPenryn 0xPenryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment to explain the fragment, otherwise looks good to me!

@0xPenryn 0xPenryn merged commit a594e48 into main Dec 28, 2023
7 checks passed
@0xPenryn 0xPenryn deleted the return_to_anchor branch December 28, 2023 21:29
This was referenced Dec 28, 2023
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
@github-actions github-actions bot mentioned this pull request Mar 30, 2024
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants