fix: Added Return_To param to request URL #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andy-t-wang
changed the title
andy-t-wang
changed the title
pdtfh
reviewed
Dec 13, 2023
packages/core/src/bridge.ts
Outdated
| )}${bridge_url && bridge_url !== DEFAULT_BRIDGE_URL ? `&b=${encodeURIComponent(bridge_url)}` : ''}`, | ||
| )}${ | ||
| bridge_url && bridge_url !== DEFAULT_BRIDGE_URL ? `&b=${encodeURIComponent(bridge_url)}` : '' | ||
| }&return_to=${encodeURIComponent(window.location.href)}`, |
There was a problem hiding this comment.
should only be appended when tapping the universal link button, this will include it in the QR code as well
pdtfh
reviewed
Dec 13, 2023
| @@ -30,7 +30,7 @@ const QRState: FC<Props> = ({ qrData, showQR, setShowQR }) => { | |||
| <> | |||
| <div className="mb-10 space-y-4 md:hidden"> | |||
| <motion.a | |||
| href={qrData ?? ''} | |||
| href={qrData ? qrData + `&return_to=${encodeURIComponent(window.location.href)}` : ''} | |||
There was a problem hiding this comment.
subsequent improvement we can handle this in the controller
pdtfh
approved these changes
Dec 13, 2023
Merged
Closed
This was referenced Jul 9, 2024
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.