name of variable "line" misleading in exercises on io

[samuelpath]

Hi,

In the solutions to the exercises my_first_io and my_first_async_io, the variable to count the number of newlines is called "lines".

This is misleading since we are not counting the number of lines per se but rather the numbre of newlines, which are two different things.

e.g.

line 1 \n
line 2 \n
line 3

In the example above, we have 3 lines but only 2 newlines.

If I'm correct, we should find a better name for the variable.
If not, could you explain what I've missed?

Cheers,
Samuel

[AnshulMalik]

I see it's newlines in https://github.com/workshopper/learnyounode/blob/master/exercises/my_first_io/problem.md

Can you point me to the file where it is line?

[samuelpath]

Hi @AnshulMalik, I meant in the solutions, like here for instance:
https://github.com/workshopper/learnyounode/blob/master/exercises/my_first_io/solution/solution.js

[AnshulMalik]

The solutions seems fine to me

[mikematthews]

This is setting us up for a fencepost error:
similar to running cat file | wc -l.
If you have a 3-line file without a newline at the end, wc -l will still return 3 because it's counting lines, not newlines.