Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to hooks useViewportMatch and useMediaQuery #19019

Conversation

jorgefilipecosta
Copy link
Member

Description

This PR just adds unit tests to useViewportMatch and useMediaQuery.
Unit tests will be useful for example to test the new simulation mechanism we are working on for useViewportMatch.

How has this been tested?

I verified the unit tests pass using run test-unit.

@jorgefilipecosta jorgefilipecosta added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] Compose /packages/compose labels Dec 9, 2019
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jorgefilipecosta jorgefilipecosta force-pushed the add/unit-tests-to-hooks-useViewportMatch-and-useMediaQuery branch from f5719ab to 8b7a51d Compare December 10, 2019 10:19
@jorgefilipecosta jorgefilipecosta merged commit ed66431 into master Dec 10, 2019
@jorgefilipecosta jorgefilipecosta deleted the add/unit-tests-to-hooks-useViewportMatch-and-useMediaQuery branch December 10, 2019 11:08
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Compose /packages/compose [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants