Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcode block #690

Closed
Tug opened this issue Feb 28, 2019 · 6 comments · Fixed by #1774
Closed

Shortcode block #690

Tug opened this issue Feb 28, 2019 · 6 comments · Fixed by #1774
Assignees
Labels

Comments

@Tug
Copy link
Contributor

Tug commented Feb 28, 2019

Add support for shortcode block

@pinarol
Copy link
Contributor

pinarol commented Dec 10, 2019

@iamthomasbishop Shortcode is one of the blocks in our next list. I am adding this to Gutenpages board to start in ~2-3 weeks. Would you like to share some designs for the mobile version? It looks pretty simple on web so we can simply try to imitate it as well.

@iamthomasbishop
Copy link
Contributor

Will do! I'll share some initial designs in the next day or 2.

@iamthomasbishop
Copy link
Contributor

@pinarol Here's a first pass, using the same styling as the code block:

image

Some notes:

  • I think re-using the text input style is a good thing, but we might want a label or icon (seen in this mock right above the text input) to distinguish between code, pre, and shortcode. The distinction between the code-based ones (code/pre) and shortcode is more necessary, imo so I explored it for this block
  • There are no block settings on this block, so I've excluded a bottom sheet

@iamthomasbishop
Copy link
Contributor

Exploring another option, with the shortcode label inside the text area:

image

@pinarol
Copy link
Contributor

pinarol commented Dec 11, 2019

Both designs seem ok to me, i find it really hard to choose between 2. Technically the 1st one is easier but I don't expect a big challenge from 2 either.

@iamthomasbishop
Copy link
Contributor

Ok, let’s roll with the first one. It does add a part to the standard block design component, or adds a variant in a way, but it is more parsable/balanced visually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants