Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent focus border from shifting block contents #551

Closed
iamthomasbishop opened this issue Feb 6, 2019 · 0 comments · Fixed by #622
Closed

Prevent focus border from shifting block contents #551

iamthomasbishop opened this issue Feb 6, 2019 · 0 comments · Fixed by #622
Assignees
@iamthomasbishop @pinarol
Labels
[Type] Bug Something isn't working
Milestone
Beta

Comments

@iamthomasbishop
Copy link
Contributor

When focusing a block, we add a 1px inset border. It looks like this is making the contents shift slightly.

Example on Android, although this is happening on iOS as well:

block-focus-shift

Are we able to use the box-shadow CSS property? Adding a box-shadow of 1px would in theory align to the outside of the block.
@iamthomasbishop iamthomasbishop added the [Type] Bug Something isn't working label Feb 6, 2019
@iamthomasbishop iamthomasbishop added this to the Beta milestone Feb 6, 2019
@iamthomasbishop iamthomasbishop self-assigned this Feb 6, 2019
@iamthomasbishop iamthomasbishop mentioned this issue Feb 6, 2019
Closed
26 tasks
@pinarol pinarol mentioned this issue Feb 20, 2019
Merged
@pinarol pinarol self-assigned this Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamthomasbishop iamthomasbishop

@pinarol pinarol

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

Add border on Title when focused wordpress-mobile/gutenberg-mobile
2 participants
@iamthomasbishop @pinarol