Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drag & Drop blocks] Crash when closing the editor while dragging (only Android) #4801

Closed
fluiddot opened this issue Apr 27, 2022 · 1 comment
Closed

[Drag & Drop blocks] Crash when closing the editor while dragging (only Android) #4801

fluiddot opened this issue Apr 27, 2022 · 1 comment
Assignees
@fluiddot
Labels
Project: Drag & Drop blocks [Type] Crash

Comments

@fluiddot
Copy link
Contributor

Description

There's an edge case where dragging a block and closing the editor at the same time leads to a crash.

Stacktrace:
AndroidRuntime: at com.swmansion.reanimated.layoutReanimation.AnimationsManager.prepareDataForAnimationWorklet(AnimationsManager.java:368)

Looks like this is a known issue (software-mansion/react-native-reanimated#2959) in the Reanimated library and there's already a fix. In order to address it, we could try either upgrade the library or apply the fix by patching the forked repository.

How to reproduce it:

  1. Start dragging a block.
  2. While moving the block around the screen, tap the back button with another finger to close the editor.
  3. Observe that the app crashes.
@fluiddot fluiddot mentioned this issue Apr 27, 2022
Merged
@fluiddot fluiddot self-assigned this May 3, 2022
@fluiddot fluiddot moved this from Todo to In Progress in Gutenberg Mobile: Drag & Drop blocks feature May 3, 2022
@fluiddot fluiddot mentioned this issue May 3, 2022
Merged
@fluiddot fluiddot mentioned this issue May 4, 2022
Merged
@fluiddot fluiddot moved this from In Progress to In Review in Gutenberg Mobile: Drag & Drop blocks feature May 4, 2022
@fluiddot
Copy link
Contributor Author

fluiddot commented May 5, 2022

This issue has been addressed in WordPress/gutenberg#40810.

@fluiddot fluiddot closed this as completed May 5, 2022
Repository owner moved this from In Review to Done in Gutenberg Mobile: Drag & Drop blocks feature May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fluiddot fluiddot

Labels
Project: Drag & Drop blocks [Type] Crash
Projects
No open projects
Gutenberg Mobile: Drag & Drop blocks feature
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fluiddot