Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting text on the more block resets it to the default text #359

Closed
koke opened this issue Dec 12, 2018 · 3 comments
Closed

Deleting text on the more block resets it to the default text #359

koke opened this issue Dec 12, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@koke
Copy link
Member

koke commented Dec 12, 2018

When you edit the text in the more block, the moment you delete it all, it resets to the default "Read more" text

https://cloudup.com/c783LjuGw_Z

@koke koke added the Blocks label Dec 12, 2018
@koke koke added this to the Alpha milestone Dec 12, 2018
@iamthomasbishop
Copy link
Contributor

Perhaps we could provide placeholder text (dimmed text, same style as our other placeholder labels) of Read More in the case where the label is empty. It would allow the user to delete all of the text, but would indicate what the default would be.

@koke
Copy link
Member Author

koke commented Dec 12, 2018

The web version seems to be using text instead of a placeholder, so I'd rather follow that (or propose the change for the web as well), although I liked the idea :)

@iamthomasbishop
Copy link
Contributor

The web version seems to be using text instead of a placeholder, so I'd rather follow that (or propose the change for the web as well), although I liked the idea :)

Fair enough. As a note on the web version. Not saying we have to solve this right away, but here's how it works (confusingly):

If you delete the text label inside GB, it is simply empty (which is fine), but then if you save it, on the front-end the label says "Continue Reading »". I expected when saving/updating that the front-end would match that – just an empty space for the block, but perhaps this is a theme-specific thing? Furthermore, when you go back to the editor, the text is back to the default "Read More" – adding to the confusion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants