Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating the device toggles off formatting options #1982

Open
maxme opened this issue Mar 5, 2020 · 1 comment
Open

Rotating the device toggles off formatting options #1982

maxme opened this issue Mar 5, 2020 · 1 comment
Labels
Project: Flow improvements Revise/enhance various editing flows [Type] Bug Something isn't working

Comments

@maxme
Copy link
Contributor

maxme commented Mar 5, 2020

Describe the bug
When the user has some formatting option selected (bold, italic, etc.) and rotates the device, this options are toggled off.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Paragraph block.
  2. Tap the bold button.
  3. Rotate the device.
  4. Notice the bold button is toggled off.

Expected behavior
I expected the button status to stay the same after rotation.

Smartphone (please complete the following information):

  • OS: Android (I haven't tested iOS)
@maxme maxme added the [Type] Bug Something isn't working label Mar 5, 2020
@mchowning
Copy link
Contributor

I recently made a change to how landscape is handled on Android so that we no longer extract the editing UI when entering landscape mode (i.e., you could still see and scroll through the post instead of having a full-screen text editing experience in landscape). I believe that may have resolved this issue, but I also think we're going to revert that fix. So although this issue may not currently be present on develop, I believe it will be "back" on develop very soon.

@hypest hypest added the Project: Flow improvements Revise/enhance various editing flows label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: Flow improvements Revise/enhance various editing flows [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants