Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide FloatingToolbar for top level blocks that doesn't have nesting capabilities #1960

Closed
pinarol opened this issue Feb 26, 2020 · 6 comments · Fixed by #1968
Closed

Hide FloatingToolbar for top level blocks that doesn't have nesting capabilities #1960

pinarol opened this issue Feb 26, 2020 · 6 comments · Fixed by #1968
Assignees
Labels

Comments

@pinarol
Copy link
Contributor

pinarol commented Feb 26, 2020

FloatingToolbar behavior was unified among different blocks with this PR. But, we are getting some feedback about how FloatingToolbar can be confusing. Let's consider hiding it for top level blocks that doesn't have nesting capabilities. @iamthomasbishop

Hello! Can someone tell me what the point of the ‘paragraph’ pop-up tag that shows up with the arrow in the Android app is? https://share.getcloudapp.com/WnuNNx0Y A user has reported these as ‘useless’ and to be honest I can’t really see what they are for neither other than identifying the block.

@pinarol pinarol added the [Status] Needs Design Review Needs design review or sign-off before shipping label Feb 26, 2020
@pinarol
Copy link
Contributor Author

pinarol commented Feb 26, 2020

@iamthomasbishop we can start this as soon as you give the 👍

@iamthomasbishop
Copy link
Contributor

Considering the position we're in (don't have the "ideal" version of the toolbar as soon as we were expecting because of technical challenges), I think this is a good next step to resolve some of the friction until we can close the gap by shipping the ideal version.

I'm not sure if it's noted anywhere, but we also should consider hiding the ⤴️ button on the toolbar for top-level blocks.

@pinarol
Copy link
Contributor Author

pinarol commented Feb 27, 2020

@jbinda could you start the work on this?

I'm not sure if it's noted anywhere, but we also should consider hiding the ⤴️ button on the toolbar for top-level blocks.

I don't think we have another issue for that. Could you describe the case for hiding that button please? How should we hide the FloatingToolbar if we remove it? @iamthomasbishop

@iamthomasbishop
Copy link
Contributor

Could you describe the case for hiding that button please?

We should hide the ⤴️ button and the separator to the right of it on all top-level blocks, whether using InnerBlocks or not because it is not possible to go "up" an additional level. Does that make sense?

@pinarol
Copy link
Contributor Author

pinarol commented Feb 28, 2020

@iamthomasbishop Sorry my question was not clear. The up button also dismisses the FloatingToolbar on top level elements, how do we dismiss the FloatingToolbar if there's no ⤴️ button? Or we just don't? It'll dismiss itself when user selects another block.

@jbinda
Copy link
Contributor

jbinda commented Feb 28, 2020

I have open new issue: #1967 to

consider hiding the ⤴️ button on the toolbar for top-level blocks.

and will post PR to revert FloatingToolbar visibility for root list block soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants