-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide FloatingToolbar for top level blocks that doesn't have nesting capabilities #1960
Comments
@iamthomasbishop we can start this as soon as you give the 👍 |
Considering the position we're in (don't have the "ideal" version of the toolbar as soon as we were expecting because of technical challenges), I think this is a good next step to resolve some of the friction until we can close the gap by shipping the ideal version. I'm not sure if it's noted anywhere, but we also should consider hiding the |
@jbinda could you start the work on this?
I don't think we have another issue for that. Could you describe the case for hiding that button please? How should we hide the FloatingToolbar if we remove it? @iamthomasbishop |
We should hide the |
@iamthomasbishop Sorry my question was not clear. The up button also dismisses the FloatingToolbar on top level elements, how do we dismiss the FloatingToolbar if there's no |
I have open new issue: #1967 to
and will post PR to revert FloatingToolbar visibility for root list block soon |
FloatingToolbar behavior was unified among different blocks with this PR. But, we are getting some feedback about how FloatingToolbar can be confusing. Let's consider hiding it for top level blocks that doesn't have nesting capabilities. @iamthomasbishop
The text was updated successfully, but these errors were encountered: