Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting text and updating paragraph alignment fails to update cursor alignment #1545

Closed
mchowning opened this issue Nov 5, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@mchowning
Copy link
Contributor

Summary

This is an iOS-specific bug that @SergioEstevao caught with the recent introduction of alignment for paragraph blocks. If you select a paragraph block with text in it, delete the text in that block, and update the alignment for the text in that block, the placeholder's alignment will be updated, but the cursor itself will not update.

To Reproduce

Step # Step Info
1a (Alternative a) Load a post with a paragraph block that already has text The text can be either aligned or unaligned. The bug will not occur if you load a post with an empty paragraph block.
1b (Alternative b) Create a new block, add text to it, and then deselect and reselect that block. Focus must leave the block in question, if you remain focused on the block the whole time then the bug will not appear.
2 Delete all the text from the paragraph block The bug appears regardless of whether you change the alignment before deleting all the text in the block
3 Update the alignment of the empty block The block must be empty, if you delete all the text and add any text back, then the bug does not appear.

Expected behavior

Updating the alignment for a paragraph block should always update the alignment of the cursor and placeholder (if the placehodler is visible).

Smartphone:

  • Device: iPhone Xr, 11
  • OS: iOS 13.1, 13.2
@SergioEstevao
Copy link
Contributor

I think this issue was sorted by these PRs:

Both of them refresh the content when deleting all the content and force relayout so they improve the refresh of cursor position.

@SergioEstevao SergioEstevao self-assigned this Nov 13, 2019
@SergioEstevao SergioEstevao added this to the 1.17 milestone Nov 13, 2019
@SergioEstevao
Copy link
Contributor

I can no longer reproduce this on release 1.17 branch so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants