Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on the latest master on gutenberg repo #1332

Closed
pinarol opened this issue Aug 27, 2019 · 1 comment · Fixed by #1366
Closed

Crash on the latest master on gutenberg repo #1332

pinarol opened this issue Aug 27, 2019 · 1 comment · Fixed by #1366
Labels
[Type] Crash
Milestone
1.12

Comments

@pinarol
Copy link
Contributor

pinarol commented Aug 27, 2019

Following crash occurs when we update gutenberg hash to point to master.

Screen Shot 2019-08-23 at 12 02 32

It looks like this PR caused this regression.
@pinarol pinarol added this to the 1.12 milestone Aug 27, 2019
@etoledom
Copy link
Contributor

We have this PR with a partial fix: WordPress/gutenberg#17228

It solves the error referenced on this ticket, but it exposes an underlying problem given the nature of the changes from WordPress/gutenberg#16932

WIP.

@pinarol pinarol mentioned this issue Aug 29, 2019
Merged
5 tasks
@Tug Tug mentioned this issue Sep 26, 2019
Merged
1 task
@Tug Tug closed this as completed in #1366 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Crash
Projects
None yet
Milestone
1.12
Development

Successfully merging a pull request may close this issue.

Fix store crash with gutenberg master wordpress-mobile/gutenberg-mobile
2 participants
@pinarol @etoledom