Move error messaging inside prettier:check script

Adding additional error messaging because with the
`--list-different` flag (which is needed to force a non-zero exit code)
and without the `--write` flag (which would cause a 0/successful exit
code) the default error messaging confusingly says both success and
error.

Author: mchowning

bin/ci-checks-js.sh

@@ -16,7 +16,7 @@ fi
 if [ "$CHECK_CORRECTNESS" = true ] ; then
   yarn flow || pFail
   yarn lint || pFail
-  yarn prettier:check || { echo "ERROR: 'yarn prettier:check' found a problem"; pFail; }
+  yarn prettier:check || pFail
 fi
 
 if [ "$GUTENBERG_AS_PARENT" = true ] ; then

package.json

@@ -53,7 +53,7 @@
   },
   "husky": {
       "hooks": {
-          "pre-commit": "yarn prettier:check || { echo '\nERROR: `yarn prettier:check` found a problem\n'; exit 1; }"
+          "pre-commit": "yarn prettier:check"
       }
   },
   "scripts": {
@@ -107,7 +107,7 @@
     "test:e2e:install-app:ios": "yarn test:e2e:build-app:ios",
     "flow": "flow",
     "prettier": "prettier-eslint --write $npm_package_config_jsfiles $npm_package_config_scssfiles",
-    "prettier:check": "prettier-eslint --list-different $npm_package_config_jsfiles $npm_package_config_scssfiles",
+    "prettier:check": "prettier-eslint --list-different $npm_package_config_jsfiles $npm_package_config_scssfiles || { echo '\nERROR: `yarn prettier:check` found a formatting problem.\nNo files have been changed. Try running `yarn prettier` to fix any formatting issues.\n'; exit 1; }",
     "clean": "yarn clean:aztec; yarn cache clean; yarn clean:haste; yarn clean:jest; yarn clean:metro; yarn clean:react; yarn clean:watchman; yarn clean:node;",
     "clean:runtime": "yarn clean:haste; yarn clean:react; yarn clean:metro; yarn clean:jest; yarn clean:watchman; yarn clean:babel-cache",
     "clean:aztec": "cd react-native-aztec && yarn clean && cd example && yarn clean",