Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RTL languages properly #7167

Closed
astralbodies opened this issue May 17, 2017 · 4 comments
Closed

Support RTL languages properly #7167

astralbodies opened this issue May 17, 2017 · 4 comments

Comments

@astralbodies
Copy link
Contributor

Original issue: https://github.com/wordpress-mobile/WordPressCom-Stats-iOS/issues/331

Related issue: #4346

Fix the stats screens to support RTL properly.

@stale
Copy link

stale bot commented Sep 4, 2019

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

@stale stale bot added the [Status] Stale label Sep 4, 2019
@designsimply
Copy link
Contributor

I checked the stats in Hebrew in the latest 13.5 beta (iPhone 6S, iOS 13.1.3) and RTL looks good on the screens I spot checked (except some of the arrows may be pointing the wrong way). Closing this issue as resolved but with a note to ask for help checking on the arrows. cc @yaelirub

IMG_3010 1 IMG_3009 1 IMG_3008 1 IMG_3007 1 IMG_3006 1 IMG_3003 1

@designsimply
Copy link
Contributor

Following up to note I found that the arrows are indeed skewampus and are on the list to be fixed in Stats Refresh v2 via #11767.

@ScoutHarris
Copy link
Contributor

skewampus

Best. Word. Ever. 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants