Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance popover fails to save settings and dismiss #23416

Closed
kean opened this issue Jul 11, 2024 · 3 comments · Fixed by #23932
Closed

Compliance popover fails to save settings and dismiss #23416

kean opened this issue Jul 11, 2024 · 3 comments · Fixed by #23932

Comments

@kean
Copy link
Contributor

kean commented Jul 11, 2024

Expected behavior

  • The popover is dismissed

Actual behavior

  • The popover is not dismissed

Workaround: Tap "Go to Settings"

Steps to reproduce the behavior

  • Install the app for the first time
  • Login with a country with GDPR
  • Add a self-hosted site
  • Verify that a compliance popover is shown
  • Tap "Save Settings"
Screen.Recording.2024-07-11.at.8.34.13.AM.mov
Tested on [device], iOS [version], Jetpack iOS / WordPress iOS [version]

trunk

Affects self-hosted sites in countries with GDPR.

@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

@kean
Copy link
Contributor Author

kean commented Jul 11, 2024

RCA

CompliancePopoverViewModel returns without doing anything if the wp.com accountId is not present:

@geriux
Copy link
Contributor

geriux commented Aug 13, 2024

I've just encountered this, I'm not sure if it's related but once I managed to close this modal, the suggestion to "Save your login credentials" system modal was behind it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants