Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions on Video/Images in Block Editor are stuck in left alignment #13022

Closed
cameronvoell opened this issue Nov 29, 2019 · 6 comments
Closed
Milestone

Comments

@cameronvoell
Copy link
Contributor

cameronvoell commented Nov 29, 2019

Introduced to WPiOS on this change: 0b6cba4
(Observe the issue does not show up after checking out previous commit - 19ed6f9)

Expected behavior

Captions should be centered

Actual behavior

Captions are left aligned

image

Steps to reproduce the behavior

  1. Edit an article in the Block Editor
  2. Add Image or Video Block and upload media
  3. Observe Caption field is left aligned instead of center
Tested on [device], iOS [version], WPiOS [version]

Tested on iPhone X iOS 12.2 emulator and iPhone XR iOS 13.2.3

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

🚫 Please add a feature label to this issue. e.g. 'Stats'

Generated by 🚫 dangerJS

@cameronvoell
Copy link
Contributor Author

I have a hunch this change included in the Aztec Update might be related: wordpress-mobile/AztecEditor-iOS#1228

Working on testing that now.

@maxme maxme added this to the 13.8 milestone Nov 29, 2019
@maxme
Copy link
Contributor

maxme commented Nov 29, 2019

Here: https://github.com/wordpress-mobile/AztecEditor-iOS/compare/issue/caption-alignemnent-fix?expand=1 - I tried to revert the changes from wordpress-mobile/AztecEditor-iOS#1228 and captions alignment got fixed.

@SergioEstevao can you have a look at this since you reviewed wordpress-mobile/AztecEditor-iOS#1228 ?

@maxme
Copy link
Contributor

maxme commented Nov 29, 2019

The bug is happening on new image or empty caption. Seems fine when you open an existing post with an existing caption.

Demo:
https://bia.is/s/M7QK/Screen_Recording_2019-11-29_at_12.08.02.mov

@maxme
Copy link
Contributor

maxme commented Nov 29, 2019

Fix in progress: WordPress/gutenberg#18818

@maxme
Copy link
Contributor

maxme commented Nov 29, 2019

Fixed by WordPress/gutenberg#18818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants