Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stats Refresh] Round the bars in the Charts #11144

Closed
ghost opened this issue Feb 25, 2019 · 2 comments
Closed

[Stats Refresh] Round the bars in the Charts #11144

ghost opened this issue Feb 25, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 25, 2019

Our Zeplin comps for the project depict bars whose top corners are rounded. This issue captures the need to perform the work.Typically this is a trivial task in iOS, but the Charts framework does not make this as easy as one might expect.

There are a few breadcrumbs from the project that chronicle the issue in more detail.

At the heart of the problem, we need to perform the following.

  1. We need to override the behavior of the default BarChartRenderer to apply the rounded corners to the bars.
  2. We need to inject said renderer, along with its animator & viewport handler in the right place within the initialization sequence.

This needs to be accomplished by either of the following:

  • PR against the canonical repository and nurse it along to completion.
  • Fork the canonical repository and synchronize changes in perpetuity.
@ghost ghost self-assigned this Feb 25, 2019
@ghost
Copy link
Author

ghost commented Feb 25, 2019

I recommend that we defer this feature from v1, due to the technical debt we'd likely incur.

It's also worth noting that our Woo colleagues present "standard" squared-off bars in their experience based on the same framework.

@ghost ghost removed their assignment Feb 25, 2019
@ghost
Copy link
Author

ghost commented May 10, 2019

Closing this, as it will not be implemented for the first iteration for the reasons noted above.

@ghost ghost closed this as completed May 10, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants