Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stats Refresh] Correct number formatting on Chart axes #11143

Closed
ghost opened this issue Feb 25, 2019 · 0 comments · Fixed by #11625
Closed

[Stats Refresh] Correct number formatting on Chart axes #11143

ghost opened this issue Feb 25, 2019 · 0 comments · Fixed by #11625

Comments

@ghost
Copy link

ghost commented Feb 25, 2019

With #11061, we constructed a chart with some stub data to match Zeplin. The formatting here is not currently locale-sensitive, nor does it match the formatting applied elsewhere in Stats.

In paCL20-3g-p2, however, we have obtained confirmation that this behavior should differ. So rather than transition to use the existing Double+Stats, we will improve the placeholder to account for broader ranges and improve locale support.

It's worth noting that our Woo colleagues have noted similar requirements both here and here.

@ghost ghost self-assigned this Feb 25, 2019
@ghost ghost mentioned this issue May 2, 2019
1 task
@ghost ghost closed this as completed in #11625 May 3, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants