Stats: Summary Data missing for a single day in-app

[ghost]

Expected behavior

As a user, I should be able to see all of my stats for a given site. This data should be consistent across platforms.

Actual behavior

For a Brazilian user noted in p1541539436037700-slack-cellular-happiness, she does not see here stats on November 4. These stats are visible on the web.

Steps to reproduce the behavior

This is a user-reported issue. We believe the locale is set to pt-BR right. It's noteworthy that this was observed after a daylight savings time transition.

Tested on [device], iOS [version], WPiOS [version]

iPhone, v11.0 ("up to date"), WP v11.0 ("up to date")

[ghost]

I asked internally in p1541622742023000-slack-portuguese-support, and another use is experiencing the same issue. In this case, however, the user's device language is set to English.

iPhone settings for second user with this issue.

[ghost]

I took some time to research the iOS implementation:

• StatsViewController uses uses -[BlogService timeZoneForBlog:]
• The value returned (e.g., GMT or America/Los Angeles is set on WPStatsViewController and injected into WPStatsService).
• WPStatsService is injected into InsightsTableViewController, where the service is invoked.
• The time zone value appears to be injected properly, but is never used in practice within WPStatsServiceRemote.
• The uses of time zone appear to be either [NSTimeZone localTimeZone] or [NSTimeZone timeZoneForSecondsFromGMT:0].
• This likely skews the parameters for before, after and date passed in requests.

cc: @ScoutHarris - for consideration while working on the Full Stats Refresh project.

[ghost]

Additional impact:

[ScoutHarris]

Thanks for doing the research @stevebaranski ! We'll keep this in mind.

cc @jklausa

[jamiepalatnik]

Reported in #1545121-zen

The user sent these screenshots.

[ScoutHarris]

@rachelmcr - can you remove this from the Groundskeeping project? I'm not sure why I can't, but this will be addressed with the Stats Refresh project. Thank you!!

[ScoutHarris]

Fixed with Stats Refresh.