Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Formatting indicator toolbar not showing correct information #10084

Closed
JavonDavis opened this issue Jun 21, 2019 · 5 comments
Closed

Comments

@JavonDavis
Copy link
Contributor

Expected behavior

Leaving some text that has already been formatted and coming back to that text should preserve existing formatting.

Actual behavior

The formatting toolbar doesn't quite match up once you leave the text you're currently editing. See below for examples

vid1

vid2

vid3

vid4

Steps to reproduce the behavior

Format some text then leave the block and come back to that text.

Tested on [device], Android [version], WPAndroid [version]

Pixel 3a, Android 9, alpha-175

@koke
Copy link
Member

koke commented Jun 24, 2019

It seems related to wordpress-mobile/gutenberg-mobile#729 although this one seems to be covering more scenarios

@JavonDavis
Copy link
Contributor Author

@koke You might be right, I've left comments both on that issue and on wordpress-mobile/gutenberg-mobile#757 (comment)

@JavonDavis
Copy link
Contributor Author

Closing here, this is already being tracked wordpress-mobile/gutenberg-mobile#729 and wordpress-mobile/gutenberg-mobile#757

@etoledom
Copy link
Contributor

etoledom commented Jun 25, 2019

Hey @JavonDavis - I left a comment here wordpress-mobile/gutenberg-mobile#729 (comment)

I think these are different issues, and wordpress-mobile/gutenberg-mobile#729 might not even be a bug :)
So I think it's better to keep this one open and close wordpress-mobile/gutenberg-mobile#729

Maybe we could move this one to the gutenberg-mobile repo? 🤔
It seems to be a gutenberg-mobile issue and not an Android specific one.

@etoledom
Copy link
Contributor

UPDATE:
I did a test on the gutenberg web, and it behaves on a very similar way.
The only difference is that the typing attributes matches the buttons status, so when you move to the end and there are no attribute buttons selected, it won't add the attributes to the new text.

That makes me thing that is Aztec Native (both iOS and Android) who add the last attributes to the typing attributes, without gutenberg telling it to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants