Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Gated Feature with an Allow/Block List #336

Open
6543 opened this issue Sep 21, 2021 · 5 comments · May be fixed by #3348
Open

Extend Gated Feature with an Allow/Block List #336

6543 opened this issue Sep 21, 2021 · 5 comments · May be fixed by #3348
Labels
enhancement improve existing features

Comments

@6543
Copy link
Member

6543 commented Sep 21, 2021

extend feature added (back) in #51


ref: https://codeberg.org/Codeberg/Community/issues/428#issuecomment-195258
ref: #193

@6543 6543 added the enhancement improve existing features label Sep 21, 2021
@6543
Copy link
Member Author

6543 commented Jul 10, 2023

#1969 created a dedicated file to handle new cases in it :)

@xoxys
Copy link
Member

xoxys commented Jul 26, 2023

Do you already have some ideas in mind on how this should be implemented? I would like to work on this, as at least for me, it gets annoying very fast 🙈

A repo setting to configure a list of authors that can be checked in https://github.com/woodpecker-ci/woodpecker/blob/main/server/pipeline/gated.go#L20

@6543
Copy link
Member Author

6543 commented Jul 26, 2023

well there are ideas like:

  • allow listing: if a user has X accepted pipelines it gets accepted automatically
  • allow listing: if the pipeline config already did run allow it automatically
  • deny listing: if pipeline target branch X make it gated ...

so basically there are rules and you could have a allow- or a deny- block-list

@xoxys
Copy link
Member

xoxys commented Jul 27, 2023

Would it make sense to integrate open policy agent for stuff like this? We could allow admins to write the own policies. We could also make use of it in e.g. extensions as proposed in #915

@anbraten
Copy link
Member

opa is a great tool, but for WP it feels to me it would add to much complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants