Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use server-host / DRONE_HOST as source for the public domain #247

Closed
anbraten opened this issue Jul 19, 2021 · 0 comments · Fixed by #251
Closed

Use server-host / DRONE_HOST as source for the public domain #247

anbraten opened this issue Jul 19, 2021 · 0 comments · Fixed by #251
Labels
enhancement improve existing features

Comments

@anbraten
Copy link
Member

anbraten commented Jul 19, 2021

Currently the request address being used to access the webinterface is for example used as base for webhooks and some links.

This is done by using httputil.GetURL(c.Request). Maybe it would be nice to use the DRONE_HOST string for these places. Currently DRONE_HOST is only used for the automatic letsencrypt setup.

Using the domain a user requested the webinterface with brings some problems:

  • if you use multiple domains to access the webinterface the current domain would be used instead of a specific one
  • you can not develop with localhost => would for example register webhooks to github, ... with localhost which is denied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants