Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large numbers abbreviated as Billion might not match the user locale #676

Closed
ctarda opened this issue Feb 12, 2019 · 3 comments
Closed

Large numbers abbreviated as Billion might not match the user locale #676

ctarda opened this issue Feb 12, 2019 · 3 comments
Labels
category: i18n Related to localization/internationalization. type: bug A confirmed bug.

Comments

@ctarda
Copy link
Member

ctarda commented Feb 12, 2019

Describe the bug
In most countries of Western Europe, a billion equals 10^12, not 10^9.

Currently, large numbers like 1.000.000.000 (1 thousand millions) will be abbreviated as 1.0b, which for the aforementioned languages will be interpreted by users as 1.000.000.000.000 (1 million millions) instead.

To Reproduce
Steps to reproduce the behavior:

  1. Generate enough sales to reach revenue of one thousand millions
  2. Go to My store
  3. Notice how the number is abbreviated as 1.0b

Expected behavior
Large numbers should be abbreviated having in mind that different countries might use different scales

@ctarda ctarda added type: bug A confirmed bug. category: i18n Related to localization/internationalization. labels Feb 12, 2019
@bummytime
Copy link
Member

Looks like our numeric abbreviations are turning out to be problematic. 😏 Thanks for pointing this out @ctarda

@bummytime
Copy link
Member

Related comment that applies here: #584 (comment)

@mindgraffiti
Copy link
Contributor

Closing in favor of #584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: i18n Related to localization/internationalization. type: bug A confirmed bug.
Projects
None yet
Development

No branches or pull requests

3 participants