This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix sort-select frontend CSS #5973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunvijwani
added
block: all products
rubikuserbot
requested review from
a team and
mikejolley
and removed request for
a team
|
Size Change: +398 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
Aljullu
reviewed
Mar 2, 2022
There was a problem hiding this comment.
Thanks for working on this @tarunvijwani! Confirming the select looks the same between the editor and the frontend with this PR! However, I'm not 100% sure that we should be adding these new CSS declarations.
The issue seems to be that some wp-admin styles are leaking into the block. That's true in the page/post editor in desktop view, but if you switch to tablet or mobile preview, that no longer happens. The issue can't be reproduced either in the Site Editor. That's because Site editor, tablet and mobile previews have the editor iframed (so styles from wp-admin don't leak into the editor).
The effort to completely iframe the page/post editor can be followed here: WordPress/gutenberg#20797.
So, thinking about it a bit more, I consider we shouldn't fix #2506 on our end. Instead, we should wait for the editor to be iframed everywhere (WordPress/gutenberg#20797), that will automatically solve our issue without us needing to change the CSS in our end.
Thoughts @tarunvijwani? Sorry for not keeping that issue up to date. 🙏
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label - otherwise it will automatically be closed after 10 days. |
github-actions
bot
added
the
status: stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CSS for the
<select>element of theAll Productsblock to provide consistent style across the frontend and page editor.Fixes #2506
Screenshots
Manual Testing
How to test the changes in this Pull Request:
All Productsblock.<select>dropdown style should match the page editor's<select>dropdown style.User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog