Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Products Block: Enabled the Inherit query from template by default when adding the block to archive template #8216

Closed
Tracked by #8059
dinhtungdu opened this issue Jan 17, 2023 · 4 comments · Fixed by #8251 or #8375
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@dinhtungdu
Copy link
Member

Is your feature request related to a problem? Please describe.

When adding the Products block to product archive templates, we should enable Inherit query from template by default. The Query Loop block does the same when adding to Archive templates.

Additional context

cc @sunyatasattva as you lead the Products block, what do you think about this?

@dinhtungdu dinhtungdu added the type: enhancement The issue is a request for an enhancement. label Jan 17, 2023
@sunyatasattva
Copy link
Contributor

Totally agree. I see you have added it to the #8059 Epic, so I assume it's going to be on your backlog, right? Or would you rather us add it to the PQ Epic?

@dinhtungdu
Copy link
Member Author

I see you have added it to the #8059 Epic, so I assume it's going to be on your backlog

Yes, @albarin is looking at this issue already.

@albarin
Copy link
Contributor

albarin commented Jan 18, 2023

@dinhtungdu @sunyatasattva quick question: should the Inherit query from template option be set to true and disabled or users should have the option to set it to false? 🤔 Thanks!

@kmanijak
Copy link
Contributor

should the Inherit query from template option be set to true and disabled or users should have the option to set it to false?

@albarin, I have discussed that with @dinhtungdu some time ago and here's the outcome of this discussion:

The Products block representing the main loop must have the Inherit query from template setting enabled. But that setting can be toggled on/off by merchants which leads to unexpected behavior. We should inform merchants about that misconfiguration to prevent confusion.

  1. User can toggle on/off the option. A use case for that is when a user wants to include more than one Products blocks:
  • a main one - option to inherit from global query enabled by default
  • an additional one - for example for featured products. In this case the user must be able to disable the option to inherit from global query.
  1. Comment mentions adding a notification that neither of Products block on the page inherits from global query, but I remember we discussed that as a nice-to-have feature that may be added in next iterations (although @dinhtungdu should confirm once he's back. Also, happy to hear @sunyatasattva opinion).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
4 participants