Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns for single products > Ensure the user can select the product they wish to use the pattern with without affecting the preview #42324

Open
nefeline opened this issue Jun 28, 2023 · 4 comments
Labels
focus: patterns WooCommerce patterns status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. team: Kirigami & Origami WC Store Editing (FSE)

Comments

@nefeline
Copy link
Contributor

nefeline commented Jun 28, 2023

This discussion started on https://github.com/woocommerce/woocommerce-blocks/pull/9935/files#r1243957131 :

Currently, as @albarin pointed out, when relying on the Single Product block for rendering the pattern, we can't display the following product selection list without affecting the preview for the Pattern:

Screenshot 2023-06-28 at 13 08 27 249402546-ea4409b9-ac02-46ea-9279-74c3a22893ba

Ideally, we should be able to:

  • Allow users to select the product they want to use the pattern with, and while doing so,
  • Allow them to preview the pattern design without any problems: the preview should match the designed pattern rather than the list of products.

This is an issue for us to investigate what can be done to achieve this (most likely, changes on Gutenberg are required to achieve this goal).

@danielwrobert
Copy link
Contributor

If we’re blocked on the preview issue noted above, perhaps another approach for improvement that we could look into would be to allow the user to change the product after insertion.

Here there would be a default product for insertion and and then the merchant/user would be able to change the product from there.

IMO, this capability would also be useful alongside the ability to select upon insertion, so it’s something that still adds value even if we can resolve the preview issue later on.

@albarin
Copy link
Contributor

albarin commented Jul 4, 2023

@nefeline @danielwrobert Just want to clarify, it is actually possible to change the product after insertion since the pattern is only a Single Product block with some custom styles 👇

CleanShot.2023-07-04.at.10.10.31.mp4

It would be nice to have a preview with a random product and then, after insertion, have the product selector open right away, but I think what we currently have is a good solution for now.

@nefeline
Copy link
Contributor Author

nefeline commented Jul 5, 2023

Just want to clarify, it is actually possible to change the product after insertion since the pattern is only a Single Product block with some custom styles

Nice! TIL

It would be nice to have a preview with a random product and then, after insertion, have the product selector open right away, but I think what we currently have is a good solution for now.

Considering that we already have a way for users to switch the product displayed while preserving the styles for the pattern, I agree that what we have now is good enough at this first moment.

@danielwrobert
Copy link
Contributor

@albarin thanks for the clarification, makes sense!

It sounds like we already have what I was suggesting then and I agree with you and @nefeline that this is a good solution for now.

@albarin albarin added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Jul 18, 2023
@nerrad nerrad added the team: Kirigami & Origami WC Store Editing (FSE) label Dec 1, 2023
@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: patterns WooCommerce patterns status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. team: Kirigami & Origami WC Store Editing (FSE)
Projects
None yet
Development

No branches or pull requests

4 participants