Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility in IPP flows #13250

Open
malinajirka opened this issue Jan 7, 2025 · 5 comments
Open

Fix accessibility in IPP flows #13250

malinajirka opened this issue Jan 7, 2025 · 5 comments
Assignees
Labels
category: accessibility Related to accessibility. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. priority: medium Planned tasks usually belonging to ongoing projects type: bug A confirmed bug.
Milestone

Comments

@malinajirka
Copy link
Contributor

malinajirka commented Jan 7, 2025

Goal of this task is to ensure IPP Flows (payments, welcome, onboarding) work as expected on devices that increase font size using accessibility setting in the OS.

Suggested solution is to wrap the content in a scrollview to at least ensure the widgets don't overlap.

In case, this solution would turn out to have side-effects, we can also consider using dp instead of sp for the texts to at least ensure changing the accessibility setting won't break the layout. Update: We decided this workaround is not acceptable as it's not accessible.

Image
@malinajirka malinajirka added type: bug A confirmed bug. priority: high Affects lots of customers substantially, but not critically. labels Jan 7, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 7, 2025

Thanks for reporting! 👍

@malinajirka malinajirka modified the milestones: 21.4, 21.5 Jan 7, 2025
@malinajirka malinajirka added priority: medium Planned tasks usually belonging to ongoing projects category: accessibility Related to accessibility. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. and removed priority: high Affects lots of customers substantially, but not critically. labels Jan 7, 2025
@Akshaykomar890
Copy link
Contributor

@malinajirka Can I work on this issue ?

@malinajirka
Copy link
Contributor Author

@Akshaykomar890 Thanks again for your interest in contributing!

Feel free to work on this issue, but beware that it likely won't be a simple or a quick one. These flows require quite a bit of setup on both the client as well as the test site. Moreover, there are many different flows (the ones mentioned above are not all the flows that require fixing). These flows are quite prone-to-breaking since the OS runs default animation that can't be easily disabled if dimensions of the dialogs differ even by one pixel, so we need to keep all the dialogs the exact same dimensions.

I don't want to discourage you too much, but at the same time I feel it's only fair to warn you about the complexity of this issue. Feel free to work on this one as well as feel free to pick a different one.

@Akshaykomar890
Copy link
Contributor

Thank you @malinajirka for the detailed explanation and for taking the time to outline the challenges of this issue. After considering the complexity and my current experience level as a beginner, I believe it would be best for me to start with smaller issues to gain a better understanding of the project. I’ll focus on those first and revisit more complex tasks like this one when I’ve built up more familiarity. Thank you again for your guidance

@wpmobilebot wpmobilebot modified the milestones: 21.5, 21.6 Jan 24, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.5 has now entered code-freeze, so the milestone of this PR has been updated to 21.6.

@samiuelson samiuelson self-assigned this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: accessibility Related to accessibility. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. priority: medium Planned tasks usually belonging to ongoing projects type: bug A confirmed bug.
Projects
None yet
Development

No branches or pull requests

5 participants