Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - New product gets "Do not sync" by default #2473

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

rawdreeg
Copy link
Contributor

@rawdreeg rawdreeg commented Feb 8, 2023

Changes proposed in this Pull Request:

In #2403, I added a default $sync_mode assignment based on sync validator checks. This is unnecessary, as we update sync mode when catalog visibility is updated (#2403). This forces $sync_mode to default to false for new products. This PR reverses the changes made by #2403 and fixes

PS: This is not really testable via unit tests, as we need an e2e test to check if the select box renders with the expected correct default value for new product.

Closes #2470.

  • Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Detailed test instructions:

  1. Checkout this branch
  2. Create a new product and click the Facebook tab. Observe that the Facebook sync mode does not default to "Do not sync"

Changelog entry

Fix - Default sync mode on new product

@rawdreeg rawdreeg requested a review from a team February 8, 2023 18:03
@rawdreeg rawdreeg self-assigned this Feb 8, 2023
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Feb 8, 2023
Copy link
Contributor

@message-dimke message-dimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Now we have a default set to Sync and show in catalogue.
Thank you, @rawdreeg !

@rawdreeg rawdreeg merged commit dbcf77d into develop Feb 9, 2023
@rawdreeg rawdreeg deleted the fix/2470-new_product_gets_do_not_sync_by_default branch February 9, 2023 21:27
@krutidugade krutidugade mentioned this pull request Jul 12, 2023
37 tasks
@ibndawood ibndawood mentioned this pull request Mar 27, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New product gets "Do not sync" by default
2 participants