Fix - New product gets "Do not sync" by default #2473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
In #2403, I added a default $sync_mode assignment based on sync validator checks. This is unnecessary, as we update sync mode when catalog visibility is updated (#2403). This forces $sync_mode to default to
false
for new products. This PR reverses the changes made by #2403 and fixesPS: This is not really testable via unit tests, as we need an e2e test to check if the select box renders with the expected correct default value for new product.
Closes #2470.
phpcs
checks? Please removephpcs:ignore
comments in changed files and fix any issues, or delete if not practical.Detailed test instructions:
Changelog entry