-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executables path does not work with a relative path #48
Comments
Thank you for the bug report and the reproduction repository. I've just tried it and the extension works as expected. What errors are coming up (if any)? |
@wongjn its the “can’t find path to executables” error toast in the bottom right hand corner. Not sure what to say other than that. Maybe it’s a macOS thing? |
Can't say for sure. Unfortunately, I do not have a Mac to test on. Is the error message exactly "Specified `phpcs` executable not found, please check your `executableFolder` setting."? |
Running it manually works fine. I wonder if it has to do with how VScode processes those relative paths on the OS. If I have time, I can try to debug it myself. Not super familiar with extension development but I can give it a shot. |
Describe the bug
Relative settings path to vendor phpcs does not work
To Reproduce
Steps to reproduce the behavior:
Expected behavior
For the executables path setting to work when the value is a relative path for the project.
Environment
Additional context
Using a full path for the executable folder setting works. Without a full path, it fails.
The text was updated successfully, but these errors were encountered: