-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing action_helper in PyPI tarball #644
Comments
I found both files... I first decompressed the tarball, then looked for both files, and I found them (both However, I haven't tried to run the tests yet. |
Oh no, you're right, the PyPI tarball (from https://pypi.org/project/nox/#files) does not contain the |
Yes, github tarball contains everything from the repo. PyPI tarballs contain only what is included by the build system - so the files are either identified or specified in pyproject.toml or manually included in tarball via MANIFEST.in. To fix this inconsistency, we can either include the action_helper.py into PyPI tarball via MANIFEST.in or use the same file for excluding the test_action_helper.py. |
cc @wntrblm/nox |
Current Behavior
In PyPI tarball, there is
test_action_helper.py
module but the module this one should test (.github/action_helper.py
) is not there.Expected Behavior
I think that the tarball should either contain both files or neither of them.
Steps To Reproduce
Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: