Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Remove mentions of Eslint #6

Closed
wmonk opened this issue Dec 29, 2016 · 1 comment
Closed

Remove mentions of Eslint #6

wmonk opened this issue Dec 29, 2016 · 1 comment

Comments

@wmonk
Copy link
Owner

wmonk commented Dec 29, 2016

There are various mentions of eslint:

package.json
10-  "bugs": {
11-    "url": "https://github.com/wmonk/create-react-app/issues"
12-  },
13-  "files": [
14-    ".babelrc",
15:    ".eslintrc",
16-    "config",
17-    "bin",
18-    "scripts",
19-    "template",
20-    "utils"

scripts/start.js
125-      console.log();
126-      messages.warnings.forEach(message => {
127-        console.log(message);
128-        console.log();
129-      });
130:      // Teach some ESLint tricks.
131-      console.log('You may use special comments to disable some warnings.');
132:      console.log('Use ' + chalk.yellow('// eslint-disable-next-line') + ' to ignore the next line.');
133:      console.log('Use ' + chalk.yellow('/* eslint-disable */') + ' to ignore all warnings in a file.');
134-    }
135-  });
136-}
137-

These should be removed/replaced with tslint, and it's corresponding config.

@chasecaleb
Copy link

Looks like this snuck back in. I'm seeing this in the current version of react-scripts-ts (2.14.0). I'm assuming it's coming from one of these two places in master:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants