Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize Pigosat's finalizer with Go convention #18

Closed
4 tasks done
wkschwartz opened this issue Sep 26, 2016 · 0 comments
Closed
4 tasks done

Harmonize Pigosat's finalizer with Go convention #18

wkschwartz opened this issue Sep 26, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@wkschwartz
Copy link
Owner

wkschwartz commented Sep 26, 2016

*os.File use a finalizer to close the file. However, it also makes the Close method publicly available so you can close the file yourself. Additionally, it clears the finalizer Close is called.

  • Make Pigosat.delete publicly available
  • Acquire write lock in Pigosat.delete
  • Close OutputFile #17
  • Clear finalizer after delete finishes
@wkschwartz wkschwartz added the bug label Sep 26, 2016
@wkschwartz wkschwartz self-assigned this Sep 26, 2016
@wkschwartz wkschwartz modified the milestone: v1.0 beta Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant