Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Solve some issues with markdown preview #470

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

albinmedoc
Copy link
Contributor

Below fixes has been implemented

  1. Ordered list rendering correctly
  2. Unordered list rendering correctly
  3. Only remove padding of the first heading-element at top level of markdown preview
  4. Change color of code-snippet to follow the theme

@wizarr-sentry wizarr-sentry bot requested review from JamsRepos, MrDynamo and a user August 1, 2024 14:35
@JamsRepos
Copy link
Member

Nice changes, i've tested these and they all work ass intended!

One thing to note though in regards to changing the colour of the code block, do you reckon we should be changing the colour of the WYSIWYG to the same as the colour scheme for the site? As the black background seems a bit out of place.

@albinmedoc
Copy link
Contributor Author

Please take a look if that was what you meant.

@albinmedoc
Copy link
Contributor Author

Ohh, I get it. That was not what you meant. Wait a moment.

@JamsRepos
Copy link
Member

Haha, for double confirmation it's the black here.

image

@JamsRepos
Copy link
Member

Bingo, you got it. Approved 🥳

@JamsRepos JamsRepos merged commit 2051990 into wizarrrr:develop Aug 1, 2024
2 checks passed
@albinmedoc
Copy link
Contributor Author

Bingo, you got it. Approved 🥳

You are fast at testing. Good job!

wizarr-sentry bot pushed a commit that referenced this pull request Aug 2, 2024
## [4.2.0-beta.2](v4.2.0-beta.1...v4.2.0-beta.2) (2024-08-02)

### New Features

* 🎊 Any length of invitation code ([#469](#469)) ([c850c8e](c850c8e))

### Bug Fixes

* 🐛 Solve issue reordering onboarding pages ([2f6ca87](2f6ca87))
* 🐛 Solve some issues with markdown preview ([#470](#470)) ([2051990](2051990))
wizarr-sentry bot pushed a commit that referenced this pull request Dec 15, 2024
## [4.2.0](v4.1.1...v4.2.0) (2024-12-15)

### New Features

* ✨ Added Onboarding Customisation ([e6e9d68](e6e9d68))
* ✨ Allow editing of all onboarding pages ([#471](#471)) ([3d4c06a](3d4c06a))
* 🎉 Add MAX_CONTENT_LENGTH configuration for file uploads ([#473](#473)) ([2edf951](2edf951))
* 🎉 Add swedish translations ([#475](#475)) ([e3b0240](e3b0240))
* 🎊 Any length of invitation code ([#469](#469)) ([c850c8e](c850c8e))
* 🎊 Make DefaultButton center icon ([#462](#462)) ([c8b8d36](c8b8d36))
* Ability to specify whether a user can download content ([#449](#449)) ([10e104b](10e104b))

### Bug Fixes

* 🐛 Solve issue reordering onboarding pages ([2f6ca87](2f6ca87))
* 🐛 Solve security alerts ([#465](#465)) ([7a958fe](7a958fe))
* 🐛 Solve some issues with markdown preview ([#470](#470)) ([2051990](2051990))
* 🛠️ Country Code for Sweden being incorrect ([#457](#457)) ([2408a59](2408a59))

### Commit Reverts

* ⏪ Change unraid configuration back to working variant ([37c5f90](37c5f90))

### Continuous Integration

* **build-image:** 🧪 bump upload-artifact version ([c6b8573](c6b8573))
* **build-image:** 🧪 drop download/upload artifact version ([0b711e1](0b711e1))
* **code-ql:** 🧪 add beta and master branch ([357e067](357e067))
* **dependabot:** 🔧 fix pip path ([1147e44](1147e44))

### Chores

* 🧽 sync develop with beta ([3de4467](3de4467))
* 🧽 sync develop with beta ([1a263de](1a263de))
* 🧽 sync develop with master ([e2b8fd4](e2b8fd4))
* **deps:** bump actions/checkout from 2 to 4 ([#431](#431)) ([4b77632](4b77632))
* **deps:** bump actions/download-artifact from 3 to 4 ([#428](#428)) ([92c7154](92c7154))
* **deps:** bump actions/setup-python from 4 to 5 ([#430](#430)) ([0d66052](0d66052))
* **deps:** bump docker/build-push-action from 5 to 6 ([#446](#446)) ([9780190](9780190))
* **deps:** bump getsentry/action-github-app-token from 2 to 3 ([#432](#432)) ([8c026d2](8c026d2))
* **deps:** bump peaceiris/actions-gh-pages from 3 to 4 ([#429](#429)) ([fdf96e5](fdf96e5))
* **deps:** bump the pip group across 1 directory with 7 updates ([#433](#433)) ([8ec9ddc](8ec9ddc))
* **deps:** bump the pip group across 1 directory with 7 updates ([#445](#445)) ([0adf394](0adf394))
* **deps:** bump tj-actions/branch-names from 7 to 8 ([#435](#435)) ([c0e7c2a](c0e7c2a))
* **release:** 4.2.0-beta.1 ([a6ea8db](a6ea8db)), closes [#462](#462) [#449](#449) [#465](#465) [#457](#457) [#431](#431) [#428](#428) [#430](#430) [#446](#446) [#432](#432) [#429](#429) [#433](#433) [#435](#435) [#458](#458)
* **release:** 4.2.0-beta.2 ([3a3bc03](3a3bc03)), closes [#469](#469) [#470](#470)
* **release:** 4.2.0-beta.3 ([f6be902](f6be902)), closes [#471](#471) [#473](#473) [#475](#475)

### Code Refactoring

* 📦 Cleanup code for darkmode ([#458](#458)) ([856fa34](856fa34))
* 🛠️ Remove auto PR [skip-ci] ([d57e726](d57e726))
@wizarr-sentry
Copy link
Contributor

wizarr-sentry bot commented Dec 15, 2024

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants