assert in manifest.cpp?

[MatthiasRInst]

Hello,

In order to track some strange issues we have with the WiX 5 bootstrapper, I have cloned the repo and build some debug builds (based on the v5.0.0 label). Yes, I am a newbie to the WiX source code.

Yesterday I have committed locally the first time. When starting the bootstrapper, the engine immediately shows an assertion from manifest.cpp, l. 180. It is in the function ValidateHarvestingAttributes(), which is called for Debug builds only:

Assert(CSTR_EQUAL == ::CompareStringW(LOCALE_INVARIANT, 0, sczEngineVersion, -1, wzVerMajorMinorBuild, -1));

By some research, I have learnt that the sczEngineVersion comes from a BurnManifest, which is generated at build time and filled with some "commit count" from git, whereas wzVerMajorMinorBuild is a constant from engine.version.h (5.0.0.0 here).
I understand that this is a nice opportunity to attach the debugger to the engine. But is there a switch to control the behaviour? or would I have to edit engine.version.h on every commit?

Best regards

Matthias

[robmen]

Off the top of my head, engine.version.h is generated by the build and should get the same number that gets "burned" into the BurnManifest. So, if you do a full build and use the wix tools you just built then the burn engine should be in sync. If you mix and match pieces from different compiles of wix then this could happen.

So, my first guess is that you're not building all of WiX to get everything in sync with itself. Try starting by debugging one of the test bundles built from the very same build.

[MatthiasRInst]

Hi Rob,
I agree: both the Manifest and engine.version.h are generated. I have run build_all.cmd, going to check what happens. Thank you.

[MatthiasRInst]

Hi Rob,
when I commit something or switch to another branch, build\wixver.props, which will then be the source from which engine.version.h will be generated, will not be updated.
I think I have found the root cause: The project internal\SetBuildNumber.proj, which is executed at the very beginning of the build sequence (from build_init.cmd), generates both ThisAssembly.WixVer.cs (which is the base e.g. for the BurnManifest) and wixver.props (which is the base for e.g. engine.version.h).
ThisAssembly.WixVer.cs is updated if something changes in Git, whereas wixver.props is not. The target "SetOverallWixVersions" is skipped if wixver.props is nwewer than the template file wixver.props.pp, regardless of git changes.

Best regards
Matthias

[MatthiasRInst]

My workaround: delete wixver.props before starting the build.

[robmen]

The README suggests running devbuild.cmd not build_all.cmd for this reason.