Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Picker to use new dialog and also fix height issues #3331

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ethanshar
Copy link
Collaborator

Description

I fixed here couple of things

  • First, I'm always using the new dialog (Incubator.Dialog) in Picker since useDialog is a new feature there's no need to go thru migration
  • There were some issues when the dialog height. When the user don't pass any height it should based the dialog height on its content. I fixed how the height is set and the layout inside PickerItemsList component

Changelog

Picker - Fix dialog UI when passing useDialog

Additional info

@adids1221 adids1221 merged commit 59b71f6 into master Oct 29, 2024
1 check passed
@adids1221 adids1221 deleted the fix/picker_default_dialog branch October 29, 2024 17:25
@hachem-benamor
Copy link

hachem-benamor commented Jan 31, 2025

@ethanshar , It seems this issue resolves the problem on iOS and not Android? It works well on iOS but not on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants