Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logical problem with prefer-lodash-typecheck #5

Closed
mik01aj opened this issue Oct 27, 2015 · 2 comments
Closed

Logical problem with prefer-lodash-typecheck #5

mik01aj opened this issue Oct 27, 2015 · 2 comments

Comments

@mik01aj
Copy link

mik01aj commented Oct 27, 2015

typeof typechecks are not always equivalent to lodash ones. Consider this example:

image

I'd like to disable the prefer-lodash-typecheck for typeof checks against "undefined".
@ganimomer
Copy link
Contributor

Thanks! Fixed in v0.1.13

@mik01aj
Copy link
Author

mik01aj commented Oct 28, 2015

👍 thanks!

Btw, I guess the documentation should be updated too:

https://github.com/wix/eslint-plugin-lodash3/blob/master/docs/rules/prefer-lodash-typecheck.md

@mik01aj mik01aj mentioned this issue Nov 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mik01aj @ganimomer