remove indexOf and lastIndexOf from list of native method, discovered…

… in #11
wix-incubator · Dec 23, 2015 · fedd20b · fedd20b
1 parent 02d1b60
commit fedd20b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/util/lodashUtil.js b/lib/util/lodashUtil.js
@@ -60,7 +60,7 @@ function getIsTypeMethod(name) {
 }
 
 function isNativeCollectionMethodCall(node) {
-    return _.includes(['every', 'fill', 'filter', 'find', 'findIndex', 'forEach', 'includes', 'indexOf', 'lastIndexOf', 'map', 'reduce', 'reduceRight', 'some'], astUtil.getMethodName(node));
+    return _.includes(['every', 'fill', 'filter', 'find', 'findIndex', 'forEach', 'includes', 'map', 'reduce', 'reduceRight', 'some'], astUtil.getMethodName(node));
 }
 
 function isLodashCollectionMethod(node) {

diff --git a/tests/lib/rules/prefer-lodash-method.js b/tests/lib/rules/prefer-lodash-method.js
@@ -17,7 +17,8 @@ ruleTester.run('prefer-lodash-method', rule, {
         'var x = _.map(arr, f)',
         'var x = _(arr).map(f).reduce(g)',
         'var x = _.chain(arr).map(f).reduce(g).value()',
-        'var x = _.keys(obj)'
+        'var x = _.keys(obj)',
+        'var x = arr.indexOf(item)'
     ],
     invalid: [{
         code: 'var x = a.map(function(x) {return x.f()});',