bump deps and fix errors

wix-incubator · Feb 15, 2022 · e6cd66f · e6cd66f
1 parent 89bc256
commit e6cd66f
Show file tree

Hide file tree

Showing 49 changed files with 6,516 additions and 3,557 deletions.
diff --git a/.gitignore b/.gitignore
@@ -21,4 +21,13 @@ sftp-config.json
 .DS_Store
 coverage
 .nyc_output
-.eslintcache
+.eslintcache
+
+# Yarn Berry
+.pnp.*
+.yarn/*
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions
diff --git a/.yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs b/.yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
diff --git a/.yarn/releases/yarn-3.1.1.cjs b/.yarn/releases/yarn-3.1.1.cjs
diff --git a/.yarnrc.yml b/.yarnrc.yml
@@ -0,0 +1,13 @@
+enableGlobalCache: true
+
+enableTelemetry: false
+
+nmMode: hardlinks-local
+
+nodeLinker: node-modules
+
+plugins:
+  - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
+    spec: "@yarnpkg/plugin-interactive-tools"
+
+yarnPath: .yarn/releases/yarn-3.1.1.cjs
diff --git a/package.json b/package.json
@@ -30,14 +30,16 @@
     "eslint": ">=2"
   },
   "devDependencies": {
-    "auto-changelog": "^2.3.0",
+    "auto-changelog": "^2.4.0",
     "coveralls": "^3.1.1",
     "cross-env": "^7.0.3",
-    "eslint": "^7.32.0",
-    "eslint-config-wix-editor": "^8.4.0",
-    "eslint-plugin-eslint-plugin": "^3.5.3",
+    "eslint": "^8.9.0",
+    "eslint-config-wix-editor": "^8.4.2",
+    "eslint-import-resolver-node": "^0.3.6",
+    "eslint-plugin-eslint-plugin": "^4.1.0",
+    "eslint-plugin-import": "^2.25.4",
     "eslint-traverser": "^1.5.2",
-    "mocha": "^9.0.3",
+    "mocha": "^9.2.0",
     "nyc": "^15.1.0"
   },
   "engines": {
@@ -52,5 +54,6 @@
   "license": "MIT",
   "dependencies": {
     "lodash": "^4.17.21"
-  }
+  },
+  "packageManager": "yarn@3.1.1"
 }
diff --git a/publish.sh b/publish.sh
@@ -0,0 +1,3 @@
+npm run minor
+npm publish --registry https://registry.npmjs.org/
+npm run version
diff --git a/src/rules/callback-binding.js b/src/rules/callback-binding.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('callback-binding')
         }

diff --git a/src/rules/chain-style.js b/src/rules/chain-style.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('chain-style')
         },

diff --git a/src/rules/chaining.js b/src/rules/chaining.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('chaining')
         },
@@ -48,7 +49,7 @@ module.exports = {
         function isNestedNLevelsInner(node, n, includeUnchainable) {
             if (n === 0) {
                 return true
-            } 
+            }
             if (lodashContext.isLodashCall(node) && (includeUnchainable || isChainable(version, getMethodName(node)))) {
                 return isNestedNLevelsInner(node.arguments[0], n - 1)
             }
@@ -92,7 +93,7 @@ module.exports = {
                 } else if (lodashContext.isLodashChainStart(node)) {
                     reportOnSingleChain(node.parent.parent)
                 }
-            } 
+            }
         }
 
         const visitors = lodashContext.getImportVisitors()

diff --git a/src/rules/collection-method-value.js b/src/rules/collection-method-value.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('collection-method-value')
         }

diff --git a/src/rules/collection-ordering.js b/src/rules/collection-ordering.js
@@ -47,6 +47,7 @@ function enforceArraysOption(node, useArray, method, context) {
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('collection-ordering')
         },

diff --git a/src/rules/collection-return.js b/src/rules/collection-return.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('collection-return')
         }

diff --git a/src/rules/consistent-compose.js b/src/rules/consistent-compose.js
@@ -13,6 +13,7 @@ const possibleDirections = ['pipe', 'compose', 'flow', 'flowRight']
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('consistent-compose')
         },

diff --git a/src/rules/identity-shorthand.js b/src/rules/identity-shorthand.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('identity-shorthand')
         },

diff --git a/src/rules/import-scope.js b/src/rules/import-scope.js
@@ -32,6 +32,7 @@ const allImportsAreOfType = (node, types) => every(node.specifiers, specifier =>
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('import-scope')
         },

diff --git a/src/rules/matches-prop-shorthand.js b/src/rules/matches-prop-shorthand.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('matches-prop-shorthand')
         },

diff --git a/src/rules/matches-shorthand.js b/src/rules/matches-shorthand.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('matches-shorthand')
         },

diff --git a/src/rules/no-commit.js b/src/rules/no-commit.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('no-commit')
         }

diff --git a/src/rules/no-double-unwrap.js b/src/rules/no-double-unwrap.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('no-double-unwrap')
         },

diff --git a/src/rules/no-extra-args.js b/src/rules/no-extra-args.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('no-extra-args')
         }

diff --git a/src/rules/no-unbound-this.js b/src/rules/no-unbound-this.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('no-unbound-this')
         }

diff --git a/src/rules/path-style.js b/src/rules/path-style.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('path-style')
         },

diff --git a/src/rules/prefer-compact.js b/src/rules/prefer-compact.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-compact')
         }

diff --git a/src/rules/prefer-constant.js b/src/rules/prefer-constant.js
@@ -11,10 +11,10 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('prefer-constant')
         },
-
         schema: [{
             type: 'boolean'
         }, {

diff --git a/src/rules/prefer-filter.js b/src/rules/prefer-filter.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('prefer-filter')
         },

diff --git a/src/rules/prefer-find.js b/src/rules/prefer-find.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-find')
         }

diff --git a/src/rules/prefer-flat-map.js b/src/rules/prefer-flat-map.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-flat-map')
         }

diff --git a/src/rules/prefer-get.js b/src/rules/prefer-get.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('prefer-get')
         },

diff --git a/src/rules/prefer-immutable-method.js b/src/rules/prefer-immutable-method.js
@@ -22,6 +22,8 @@ const forEach = require('lodash/forEach')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-immutable-method')
         }
@@ -35,7 +37,7 @@ module.exports = {
             forEach(mutatingMethods, (preferred, mutatingMethod) => {
                 if (isAliasOfMethod(version, mutatingMethod, method)) {
                     context.report({
-                        node, 
+                        node,
                         message: `Prefer _.${preferred} instead of _.${mutatingMethod}`
                     })
                 }

diff --git a/src/rules/prefer-includes.js b/src/rules/prefer-includes.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('prefer-includes')
         },

diff --git a/src/rules/prefer-invoke-map.js b/src/rules/prefer-invoke-map.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-invoke-map')
         }

diff --git a/src/rules/prefer-is-nil.js b/src/rules/prefer-is-nil.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-is-nil')
         }

diff --git a/src/rules/prefer-lodash-chain.js b/src/rules/prefer-lodash-chain.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-lodash-chain')
         }

diff --git a/src/rules/prefer-lodash-method.js b/src/rules/prefer-lodash-method.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('prefer-lodash-method')
         },

diff --git a/src/rules/prefer-lodash-typecheck.js b/src/rules/prefer-lodash-typecheck.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-lodash-typecheck')
         }

diff --git a/src/rules/prefer-map.js b/src/rules/prefer-map.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-map')
         }

diff --git a/src/rules/prefer-matches.js b/src/rules/prefer-matches.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('prefer-matches')
         },

diff --git a/src/rules/prefer-noop.js b/src/rules/prefer-noop.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-noop')
         }

diff --git a/src/rules/prefer-over-quantifier.js b/src/rules/prefer-over-quantifier.js
@@ -11,6 +11,8 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
+        schema: [],
         docs: {
             url: getDocsUrl('prefer-over-quantifier')
         }

diff --git a/src/rules/prefer-reject.js b/src/rules/prefer-reject.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('prefer-reject')
         },

diff --git a/src/rules/prefer-some.js b/src/rules/prefer-some.js
@@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl')
 
 module.exports = {
     meta: {
+        type: 'problem',
         docs: {
             url: getDocsUrl('prefer-some')
         },
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,6 +11,7 @@ const getDocsUrl = require('../util/getDocsUrl') @@
     module.exports = {
         meta: {
+            type: 'problem',
             docs: {
                 url: getDocsUrl('chain-style')
             },
@@ Expand Down @@