fix bug in prefer-times where it works on native-map

wix-incubator · Nov 22, 2015 · dec6a1f · dec6a1f
1 parent b064156
commit dec6a1f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/rules/prefer-times.js b/lib/rules/prefer-times.js
@@ -17,7 +17,7 @@ module.exports = function (context) {
     }
 
     function handleFunctionExpression(node) {
-        if (lodashUtil.isCallToMethod(node.parent, 'map')) {
+        if (lodashUtil.isCallToMethod(node.parent, 'map') && (lodashUtil.isLodashCall(node.parent) || lodashUtil.isLodashWrapper(node.parent))) {
             callStack.push({func: node, params: _.map(node.params, getParamName), anyUsed: false});
         }
     }

diff --git a/tests/lib/rules/prefer-times.js b/tests/lib/rules/prefer-times.js
@@ -19,8 +19,9 @@ ruleTester.run('prefer-times', rule, {
         '_.forEach(arr, function() {f(g(r)); })',
         'var results = _.times(arr.length, function() {return Math.random();})',
         'var x = _.map(a, "prop");',
-        'var x = _.map(arr, function(a) {return _.map(a, function(b) {return b + 1});});'
-    ],
+        'var x = _.map(arr, function(a) {return _.map(a, function(b) {return b + 1});});',
+        "var x = arr.map(function () {return str; }).join('')"
+],
     invalid: [{
         code: '_(arr).map(function(){return g}).value()',
         errors: errors