refactor in the "chaining" rule

wix-incubator · Dec 9, 2018 · c8b0ff3 · c8b0ff3
1 parent 85084a9
commit c8b0ff3
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/src/rules/chaining.js b/src/rules/chaining.js
@@ -67,15 +67,18 @@ module.exports = {
             }
         }
 
+        function reportOnSingleChain(node) {
+            if (isMethodCall(node) && (isEndOfChain(node) || isBeforeChainBreaker(node))) {
+                context.report({node, messageId: 'single'})
+            }
+        }
+
         const callExpressionVisitors = {
             always: node => {
                 if (isNestedNLevels(node, ruleDepth, true)) {
                     context.report({node, messageId: 'always'})
                 } else if (lodashContext.isLodashChainStart(node)) {
-                    const firstCall = node.parent.parent
-                    if (isMethodCall(firstCall) && (isEndOfChain(firstCall) || isBeforeChainBreaker(firstCall))) {
-                        context.report({node: firstCall, messageId: 'single'})
-                    }
+                    reportOnSingleChain(node.parent.parent)
                 }
             },
             never: node => {
@@ -87,10 +90,7 @@ module.exports = {
                 if (isNestedNLevels(node, ruleDepth, false)) {
                     context.report({node, messageId: 'always'})
                 } else if (lodashContext.isLodashChainStart(node)) {
-                    const firstCall = node.parent.parent
-                    if (isMethodCall(firstCall) && (isEndOfChain(firstCall) || isBeforeChainBreaker(firstCall))) {
-                        context.report({node: firstCall, messageId: 'single'})
-                    }
+                    reportOnSingleChain(node.parent.parent)
                 }
             } 
         }