update dependencies and fix lint

package.json

@@ -29,23 +29,23 @@
     "eslint": ">=2.10.0"
   },
   "dependencies": {
-    "lodash": "~4.17.0"
+    "lodash": "4.17.10"
   },
   "devDependencies": {
-    "babel-cli": "6.24.1",
-    "babel-plugin-istanbul": "4.1.1",
+    "babel-cli": "6.26.0",
+    "babel-plugin-istanbul": "4.1.6",
     "babel-preset-es2015": "6.24.1",
-    "babel-register": "6.24.1",
-    "coveralls": "2.13.0",
-    "cross-env": "4.0.0",
-    "eslint": "3.19.0",
-    "eslint-config-wix-editor": "0.2.3",
-    "eslint-plugin-eslint-plugin": "^0.8.0",
+    "babel-register": "6.26.0",
+    "coveralls": "3.0.1",
+    "cross-env": "5.2.0",
+    "eslint": "4.19.1",
+    "eslint-config-wix-editor": "3.4.0",
+    "eslint-plugin-eslint-plugin": "1.4.0",
     "eslint-traverser": "1.5.2",
     "istanbul": "^0.4.4",
-    "mocha": "3.3.0",
-    "nyc": "10.2.0",
-    "rimraf": "2.6.1"
+    "mocha": "5.2.0",
+    "nyc": "12.0.2",
+    "rimraf": "2.6.2"
   },
   "engines": {
     "node": ">=0.12.0"

src/index.js

@@ -11,7 +11,7 @@ const recommended = {
         'lodash/chaining': 2,
         'lodash/collection-method-value': 2,
         'lodash/collection-return': 2,
-        'lodash/consistent-compose': [2, "flow"],
+        'lodash/consistent-compose': [2, 'flow'],
         'lodash/identity-shorthand': [2, 'always'],
         'lodash/import-scope': [2],
         'lodash/matches-prop-shorthand': [2, 'always'],
@@ -72,7 +72,7 @@ module.exports = {
                 'lodash/chaining': [2, 'always'],
                 'lodash/collection-method-value': 2,
                 'lodash/collection-return': 2,
-                'lodash/consistent-compose': [2, "flow"],
+                'lodash/consistent-compose': [2, 'flow'],
                 'lodash/import-scope': [2, 'full'],
                 'lodash/identity-shorthand': [2, 'always'],
                 'lodash/matches-prop-shorthand': [2, 'always'],

src/rules/callback-binding.js

@@ -21,7 +21,6 @@ module.exports = {
         const {getFunctionMaxArity} = require('../util/methodDataUtil')
         const {getMethodName} = require('../util/astUtil')
         const {version} = require('../util/settingsUtil').getSettings(context)
-        const includes = require('lodash/includes')
 
         function isBound(node) {
             return node && node.type === 'CallExpression' && getMethodName(node) === 'bind' && node.arguments.length === 1

src/rules/chaining.js

@@ -24,7 +24,7 @@ module.exports = {
 
     create(context) {
         const {getLodashContext, isChainBreaker} = require('../util/lodashUtil')
-        const {getCaller, isMethodCall, isObjectOfMethodCall} = require('../util/astUtil')
+        const {isMethodCall, isObjectOfMethodCall} = require('../util/astUtil')
         const DEFAULT_LENGTH = 3
         const lodashContext = getLodashContext(context)
         const version = lodashContext.version

src/rules/identity-shorthand.js

@@ -53,6 +53,5 @@ module.exports = {
             always: 'Prefer omitting the iteratee over a function that returns its argument',
             never: 'Do not use the identity shorthand syntax'
         })
-
     }
 }

src/rules/import-scope.js

@@ -48,10 +48,8 @@ module.exports = {
                 if (isFullLodashImport(node.source.value)) {
                     if (importType === 'method' || importType === 'method-package') {
                         context.report({node, message: messages[importType]})
-                    } else {
-                        if (!allImportsAreOfType(node, importNodeTypes[importType])) {
-                            context.report({node, message: messages[importType]})
-                        }
+                    } else if (!allImportsAreOfType(node, importNodeTypes[importType])) {
+                        context.report({node, message: messages[importType]})
                     }
                 } else if ((isMethodImport(node.source.value) && importType !== 'method') ||
                            (isMethodPackageImport(node.source.value) && importType !== 'method-package')) {

src/rules/no-double-unwrap.js

@@ -14,7 +14,7 @@ module.exports = {
         docs: {
             url: getDocsUrl('no-double-unwrap')
         },
-        fixable: "code"
+        fixable: 'code'
     },
 
     create(context) {

src/rules/path-style.js

@@ -30,7 +30,6 @@ module.exports = {
         const findIndex = require('lodash/findIndex')
         const some = require('lodash/some')
         const every = require('lodash/every')
-        const get = require('lodash/get')
         const matches = require('lodash/matches')
         const isPropAccess = x => x === '.' || x === '['
 

src/rules/prefer-lodash-chain.js

@@ -24,7 +24,7 @@ module.exports = {
         const version = lodashContext.version
 
         const visitors = lodashContext.getImportVisitors()
-        visitors.CallExpression = function(node) {
+        visitors.CallExpression = function (node) {
             if (lodashContext.isLodashChainStart(node)) {
                 do {
                     node = node.parent.parent

src/rules/prefer-lodash-method.js

@@ -34,33 +34,29 @@ module.exports = {
     },
 
     create(context) {
-
         const {getLodashContext, isNativeCollectionMethodCall, getLodashMethodCallExpVisitor} = require('../util/lodashUtil')
         const {getMethodName, getCaller} = require('../util/astUtil')
         const {methodExists} = require('../util/methodDataUtil')
-        const keys = require('lodash/keys')
         const get = require('lodash/get')
         const includes = require('lodash/includes')
-        const matches = require('lodash/matches')
         const some = require('lodash/some')
-        const map = require('lodash/map')
         const assign = require('lodash/assign')
         const ignoredMethods = get(context, ['options', 0, 'ignoreMethods'], [])
         const ignoredObjects = get(context, ['options', 0, 'ignoreObjects'], [])
         const usingLodash = new Set()
 
         const nativeStringMap = {
-          endsWith: 'endsWith',
-          includes: 'includes',
-          padEnd: 'padEnd',
-          padStart: 'padStart',
-          repeat: 'repeat',
-          replace: 'replace',
-          split: 'split',
-          startsWith: 'startsWith',
-          toLowerCase: 'toLower',
-          toUpperCase: 'toUpper',
-          trim: 'trim'
+            endsWith: 'endsWith',
+            includes: 'includes',
+            padEnd: 'padEnd',
+            padStart: 'padStart',
+            repeat: 'repeat',
+            replace: 'replace',
+            split: 'split',
+            startsWith: 'startsWith',
+            toLowerCase: 'toLower',
+            toUpperCase: 'toUpper',
+            trim: 'trim'
         }
 
         const lodashContext = getLodashContext(context)
@@ -112,7 +108,7 @@ module.exports = {
                 if (!usingLodash.has(node) && !shouldIgnore(node) && canUseLodash(node)) {
                     let lodashMethodName = getMethodName(node)
                     if (isNativeStringMethodCall(node)) {
-                      lodashMethodName = nativeStringMap[lodashMethodName]
+                        lodashMethodName = nativeStringMap[lodashMethodName]
                     }
                     context.report({node, message: `Prefer '_.${lodashMethodName}' over the native function.`})
                 }

src/rules/prefer-wrapper-method.js

@@ -20,7 +20,7 @@ module.exports = {
         const {isLodashWrapperMethod, getLodashContext} = require('../util/lodashUtil')
         const lodashContext = getLodashContext(context)
         const visitors = lodashContext.getImportVisitors()
-        visitors.CallExpression = function(node) {
+        visitors.CallExpression = function (node) {
             if (lodashContext.isLodashChainStart(node) && isLodashWrapperMethod(node.arguments[0], lodashContext.version)) {
                 context.report({node, message: 'Prefer {{name}} with wrapper method over inside the chain start.', data: {name: node.arguments[0].callee.property.name}})
             }

src/rules/unwrap.js

@@ -36,7 +36,7 @@ module.exports = {
         }
 
         const visitors = lodashContext.getImportVisitors()
-        visitors.CallExpression = function(node) {
+        visitors.CallExpression = function (node) {
             if (lodashContext.isImplicitChainStart(node)) {
                 const end = getEndOfChain(node, false)
                 if (!isCommit(end) && isChainable(end, version)) {

src/util/LodashContext.js

@@ -30,7 +30,7 @@ module.exports = class {
                             case 'ImportNamespaceSpecifier':
                             case 'ImportDefaultSpecifier':
                                 self.general[spec.local.name] = true
-                                    break
+                                break
                             case 'ImportSpecifier':
                                 self.methods[spec.local.name] = spec.imported.name
                                 break

src/util/getDocsUrl.js

@@ -13,5 +13,5 @@ const REPO_URL = 'https://github.com/wix/eslint-plugin-lodash'
 * @returns {string} URL to the documentation for the given rule
 */
 module.exports = function getDocsUrl(ruleName) {
-   return `${REPO_URL}/blob/v${pkg.version}/docs/rules/${ruleName}.md`
+    return `${REPO_URL}/blob/v${pkg.version}/docs/rules/${ruleName}.md`
 }

src/util/lodashUtil.js

@@ -2,7 +2,6 @@
 const _ = require('lodash')
 const methodDataUtil = require('./methodDataUtil')
 const astUtil = require('./astUtil')
-const settingsUtil = require('./settingsUtil')
 const LodashContext = require('./LodashContext')
 
 /**
@@ -148,7 +147,7 @@ function getLodashContext(context) {
 module.exports = {
     isChainable,
     isChainBreaker,
-isCallToMethod,
+    isCallToMethod,
     isLodashWrapperMethod,
     getIsTypeMethod,
     isNativeCollectionMethodCall,