Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End support in RN .44, .45 #1203

Closed
d4vidi opened this issue Mar 13, 2019 · 1 comment
Closed

End support in RN .44, .45 #1203

d4vidi opened this issue Mar 13, 2019 · 1 comment

Comments

@d4vidi
Copy link
Collaborator

d4vidi commented Mar 13, 2019

On Android, Detox supports RN version ranges [.44, .46) and [.46, inf) using two separate build flavours. Now that versions .45 and .44 are both almost 2 years old now, I think it's safe to make .46 the new minimum. This is of additional importance as we move forward towards .aar publishing integration (i.e. #955), as it would simplify the jars and aars package structure (on top of the build scripts themselves).

@rotemmiz @LeoNatan your take on this?

@d4vidi d4vidi changed the title Remove support in RN .44, .45 End support in RN .44, .45 Mar 13, 2019
@rotemmiz
Copy link
Member

https://media.tenor.com/images/e1cbe9b369d835299eb3eeee8144f948/tenor.gif

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants