Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 RFC: infer props and params from getStaticParams in ApiContext (endpoints) #663

Closed
1 of 3 tasks
florian-lefebvre opened this issue Oct 10, 2023 · 0 comments
Closed
1 of 3 tasks
Labels
pkg: ts-plugin Fixes to the TS plugin are required to fix this issue (scope)

Comments

@florian-lefebvre
Copy link
Member

Background & Motivation

Following withastro/compiler#873, I think it would be great to allow the same behavior with the ApiContext type (in endpoints) which accepts Props and Params.

Proposed Solution

After talking on Discord with @Princesseuh, looks like this file is where things should happen.

Detailed Design

A few resources shared by Erika:

Help make it happen!

  • I am willing to submit a PR to implement this change.
  • I am willing to submit a PR to implement this change, but would need some guidance.
  • I am not willing to submit a PR to implement this change.
@Princesseuh Princesseuh added the pkg: ts-plugin Fixes to the TS plugin are required to fix this issue (scope) label Oct 11, 2023
@withastro withastro locked and limited conversation to collaborators Nov 12, 2023
@Princesseuh Princesseuh converted this issue into discussion #688 Nov 12, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
pkg: ts-plugin Fixes to the TS plugin are required to fix this issue (scope)
Projects
None yet
Development

No branches or pull requests

2 participants