Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types inside of tests #1021

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Fix types inside of tests #1021

merged 8 commits into from
Jul 15, 2024

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Jul 11, 2024

Changes

This repo always had typed tests, however since the tsconfig.json was using moduleResolution: 'node' (the only option that existed at the time), a lot of the types failed to resolve and resulted in any. This PR fixes this and does all the changes required to make it work

Testing

Tests should pass!

Docs

N/A

Copy link

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: 89f782a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from chore/format-all to main July 12, 2024 10:17
@Princesseuh Princesseuh merged commit ed25fe0 into main Jul 15, 2024
5 checks passed
@Princesseuh Princesseuh deleted the fix/tests-type branch July 15, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants