From 6d3f0981657e33c7587b674fd9203ca57f424563 Mon Sep 17 00:00:00 2001 From: Princesseuh <3019731+Princesseuh@users.noreply.github.com> Date: Thu, 11 Jan 2024 12:28:49 -0500 Subject: [PATCH 1/2] fix(assets): Implement all hooks in the passthrough image service --- packages/astro/src/assets/services/noop.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/astro/src/assets/services/noop.ts b/packages/astro/src/assets/services/noop.ts index 38d7dbdb65e2..fe6cc7c922e5 100644 --- a/packages/astro/src/assets/services/noop.ts +++ b/packages/astro/src/assets/services/noop.ts @@ -2,11 +2,8 @@ import { baseService, type LocalImageService } from './service.js'; // Empty service used for platforms that neither support Squoosh or Sharp. const noopService: LocalImageService = { + ...baseService, propertiesToHash: ['src'], - validateOptions: baseService.validateOptions, - getURL: baseService.getURL, - parseURL: baseService.parseURL, - getHTMLAttributes: baseService.getHTMLAttributes, async transform(inputBuffer, transformOptions) { return { data: inputBuffer, From c9e2a62e06681e78baf837c9c6554fda17f62224 Mon Sep 17 00:00:00 2001 From: Princesseuh <3019731+Princesseuh@users.noreply.github.com> Date: Thu, 11 Jan 2024 12:29:57 -0500 Subject: [PATCH 2/2] chore: changeset --- .changeset/long-mangos-walk.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/long-mangos-walk.md diff --git a/.changeset/long-mangos-walk.md b/.changeset/long-mangos-walk.md new file mode 100644 index 000000000000..efa85cb9afb0 --- /dev/null +++ b/.changeset/long-mangos-walk.md @@ -0,0 +1,5 @@ +--- +"astro": patch +--- + +Fix the passthrough image service not generating `srcset` values properly