Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vercel adapter 3.7.0 or higher fails to build when includeFiles is present #7667

Closed
1 task done
raulfdm opened this issue Jul 15, 2023 · 2 comments · Fixed by #7677
Closed
1 task done

Vercel adapter 3.7.0 or higher fails to build when includeFiles is present #7667

raulfdm opened this issue Jul 15, 2023 · 2 comments · Fixed by #7677
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) feat: ssr Related to SSR (scope) pkg: vercel Related to Vercel adapter (scope)

Comments

@raulfdm
Copy link
Contributor

raulfdm commented Jul 15, 2023 •
edited
Loading

What version of astro are you using?

2.8.3

Are you using an SSR adapter? If so, which one?

Vercel

What package manager are you using?

pnpm

What operating system are you using?

Mac

What browser are you using?

not relevant

Describe the Bug

I notice after upgrading @astrojs/vercel to 3.7.0 or higher because I use includeFiles, it throws an error:

Cannot read properties of undefined (reading 'root')
  File:
    /home/projects/withastro-astro-768xre/node_modules/.pnpm/@astrojs+vercel@3.7.2_astro@2.8.3_react@18.2.0/node_modules/@astrojs/vercel/dist/serverless/adapter.js:70:108

To reproduce, open the stackblitz repository and run pnpm run build.

If you switch to using vercel36 (another vercel adapter version [3.6.0]), it'll work just fine.

What's the expected result?

Not throwing an error while building.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/withastro-astro-768xre?file=README.md

Participation

  • I am willing to submit a pull request for this issue.
@raulfdm
Copy link
Contributor Author

raulfdm commented Jul 15, 2023

CleanShot.2023-07-15.at.17.25.06.mp4

@raulfdm raulfdm changed the title Vercel adapter 3.7.0 or higher fails to build when includeFiles is preset Vercel adapter 3.7.0 or higher fails to build when includeFiles is present Jul 16, 2023
@bluwy bluwy added - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) pkg: vercel Related to Vercel adapter (scope) labels Jul 17, 2023
@Princesseuh Princesseuh added the feat: ssr Related to SSR (scope) label Jul 17, 2023
@bluwy bluwy mentioned this issue Jul 17, 2023
Merged
@raulfdm
Copy link
Contributor Author

raulfdm commented Jul 17, 2023

Thanks @bluwy 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) feat: ssr Related to SSR (scope) pkg: vercel Related to Vercel adapter (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix vercel build error when passing includeFiles withastro/astro
3 participants
@Princesseuh @raulfdm @bluwy