Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Stray comma rendered when slot fallback includes component followed by HTML content #1605

Closed
innermatrix opened this issue Oct 20, 2021 · 2 comments
Milestone

Comments

@innermatrix
Copy link

innermatrix commented Oct 20, 2021

What package manager are you using?

npm

What operating system are you using?

macOS

Describe the Bug

Rendering a component like

<html>
  <body>
    <slot>
      <BodyComponent />
      <div>two</div>
    </slot>
  </body>
</html>

ends up with a , between the content of BodyComponent and the div that follows it

Steps to Reproduce

Look at the rendering of index.astro in supplied MWE. The component causing the problem is MainComponent.astro

Link to Minimal Reproducible Example (Optional)

https://stackblitz.com/edit/astro-dj3jh6

@natemoo-re
Copy link
Member

Fixed in #1406, it seems! Thanks for opening an issue.

See https://stackblitz.com/edit/astro-zcjh8p?file=src%2Fcomponents%2FMainComponent.astro for a working repro with next.

@natemoo-re natemoo-re added this to the v0.21 milestone Nov 1, 2021
@natemoo-re
Copy link
Member

Following up on my previous comment, the team has decided to close out issues that have been confirmed as fixed by astro@0.21.0-next.0, astro@0.21.0-next.1, or astro@0.21.0-next.2. Our hope is that this will help the v0.21 milestone remain as actionable as possible.

To verify that this issue has been fixed, you may

  • Open a new astro@next project on StackBlitz
  • Locally upgrade to the astro@next preview
    npm i astro@next
    # If using Framework renderers...
    npm i @astrojs/renderer-name@next

If you think we made a mistake, please re-open this issue!

If you run into any other problems with astro@next, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants