Thanks! PR would be appreciated in this case.

Thanks! PR would be appreciated in this case.

I'll try it!, but which one is the good url? with or without file extension? 😅

The one without .html should be the correct one

The one without .html should be the correct one

I've been investigating and, from what I've discovered (it's my first time delving into the inner workings of Astro), the URL generated during the build process adds the .html extension if build.format is set to "file" https://github.com/withastro/astro/blob/main/packages/astro/src/core/build/generate.ts#L402.

This makes me question whether the correct URL should indeed exclude the .html, since it seems to be intentionally included.

That's the correct URL during the build, but you want to generate a URL that users want to navigate to, and usually users want to have a URL without the html extension

That's the correct URL during the build, but you want to generate a URL that users want to navigate to, and usually users want to have a URL without the html extension

But AFAIK the URL during the build is the one used by Astro.url.pathname, that's why the canonical url in the build has the .html extension, should the canonical url be formed without the pathname?

I believe this is caused by this change.

It makes the URLs in the sitemap use the format https://astro.build/page2 when this is true: if (astroConfig.trailingSlash === 'never' || astroConfig.build.format === 'file').

That PR also also makes it difficult to migrate to astroConfig.trailingSlash = 'never' from the default value of ignore, because when you change that setting, your existing URLs indexed by search engines will return 404's. I think you can solve that by setting up redirects, which isn't ideal IMO.

The logic for generating the URL is scattered across different places, and in the end, that's what's causing problems:

• sitemap/index
• sitemap/write-sitemap
• core/build/generate This generates the paths that are used in the canonical URL during the build (and adds the .html)

I think we could create a utility that generates the URLs (or paths) based on the Astro configuration, and that it should be used everywhere

I ended up with simple fix, I would like to create that useful but I don't have the knowledge yet for doing it right 😞