Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiki code blocks in markdown ignore "meta" part #10475

Closed
1 task
madcampos opened this issue Mar 18, 2024 · 0 comments · Fixed by #10494
Closed
1 task

Shiki code blocks in markdown ignore "meta" part #10475

madcampos opened this issue Mar 18, 2024 · 0 comments · Fixed by #10494
Assignees
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) feat: markdown Related to Markdown (scope)

Comments

@madcampos
Copy link
Contributor

Astro Info

Astro                    v4.5.5
Node                     v20.11.0
System                   macOS (arm64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             @vite-pwa/astro-integration
                         @astrojs/sitemap
                         astro-icon

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

All shiki transformers that use the meta part of a code block don't work.

E.g.: transformerMetaHighlight and twoslash

```ts {1,3-4} <- this part after the "ts"
```ts twoslash <- this part after the "ts"

What's the expected result?

Using those transformers should enable twoslash or highlight the lines per the transformers documentation.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/md-meta-issue

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Mar 18, 2024
@bluwy bluwy added feat: markdown Related to Markdown (scope) - P4: important Violate documented behavior or significantly impacts performance (priority) and removed needs triage Issue needs to be triaged labels Mar 18, 2024
@bluwy bluwy self-assigned this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) feat: markdown Related to Markdown (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants