From 86a33915ff41b23ff6b35bcfb1805fefc0760ca7 Mon Sep 17 00:00:00 2001 From: Emanuele Stoppa Date: Tue, 20 Aug 2024 07:45:59 +0100 Subject: [PATCH] fix: adapter features messaging (#11773) * fix: adapter features messaging * Apply suggestions from code review Co-authored-by: Sarah Rainsberger * Update .changeset/long-months-burn.md Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com> --------- Co-authored-by: Sarah Rainsberger Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com> --- .changeset/long-months-burn.md | 5 +++++ packages/astro/src/integrations/features-validation.ts | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/long-months-burn.md diff --git a/.changeset/long-months-burn.md b/.changeset/long-months-burn.md new file mode 100644 index 000000000000..4b11c58a17c1 --- /dev/null +++ b/.changeset/long-months-burn.md @@ -0,0 +1,5 @@ +--- +'astro': patch +--- + +Changes messages logged when using unsupported, deprecated, or experimental adapter features for clarity diff --git a/packages/astro/src/integrations/features-validation.ts b/packages/astro/src/integrations/features-validation.ts index 87de3592b726..bd08a876d241 100644 --- a/packages/astro/src/integrations/features-validation.ts +++ b/packages/astro/src/integrations/features-validation.ts @@ -124,20 +124,20 @@ function validateSupportKind( } function featureIsUnsupported(adapterName: string, logger: Logger, featureName: string) { - logger.error('config', `The feature "${featureName}" is not supported (used by ${adapterName}).`); + logger.error('config', `The adapter ${adapterName} doesn't currently support the feature "${featureName}".`); } function featureIsExperimental(adapterName: string, logger: Logger, featureName: string) { logger.warn( 'config', - `The feature "${featureName}" is experimental and subject to change (used by ${adapterName}).`, + `The adapter ${adapterName} provides experimental support for "${featureName}". You may experience issues or breaking changes until this feature is fully supported by the adapter.`, ); } function featureIsDeprecated(adapterName: string, logger: Logger, featureName: string) { logger.warn( 'config', - `The feature "${featureName}" is deprecated and will be removed in the future (used by ${adapterName}).`, + `The adapter ${adapterName} has deprecated its support for "${featureName}", and future compatibility is not guaranteed. The adapter may completely remove support for this feature without warning.`, ); }